Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: add missing rss feed links #249

Merged
merged 2 commits into from
Oct 14, 2024
Merged

cleanup: add missing rss feed links #249

merged 2 commits into from
Oct 14, 2024

Conversation

GabsEdits
Copy link
Member

Preview

Live Deployment: https://fix-wording.gabs.pages.dev/

kbdharun
kbdharun approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Interesting, even through the implementation is same in the developers program page alone there is a small underline.

image

Edit. It is still present now.

@GabsEdits
Copy link
Member Author

GabsEdits commented Oct 6, 2024 •
edited
Loading

Interesting, even through the implementation is same in the developers program page alone there is a small underline.

Hmm, it seems that it's due to the button being an a and the email one an div, I'll see what I can do

@GabsEdits
Copy link
Member Author

I've migrated it to an button just in case
Screenshot 2024-10-14 at 12 26 54

@GabsEdits GabsEdits merged commit 31627a2 into Vanilla-OS:v2 Oct 14, 2024
1 check passed
@kbdharun kbdharun deleted the fix-wording branch October 15, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@mirkobrombin mirkobrombin mirkobrombin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabsEdits @mirkobrombin @kbdharun