Env variables #813
Env variables #813
Conversation
|
Code Climate has analyzed commit bb63e68 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (0% is the threshold). This pull request will bring the total coverage in the repository to 63.4% (0.0% change). View more on Code Climate. |
.env.template
Outdated
| "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs", \ | ||
| "client_x509_cert_url": "acerturl" \ | ||
| }' | ||
| GCP_STORAGE_SERVICE_ACCOUNT='{"type":"service_account","project_id":"foo","private_key_id":"aprivatekey","private_key": "anotherprivatekey","client_email": "[email protected]","client_id": "aclientid","auth_uri": "https://accounts.google.com/o/oauth2/auth","token_uri": "https://oauth2.googleapis.com/token","auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs","client_x509_cert_url": "acerturl"}' |
There was a problem hiding this comment.
Probably better to break this up? Makes it easier to read?
There was a problem hiding this comment.
Perhaps leave a comment above it reminding whoever uses the template to remove the spaces?
There was a problem hiding this comment.
yeah, rationale was that I was a dumdum and just assumed the formatting was how it was supposed to be and disregarded the README but that's fair point, will revert
There was a problem hiding this comment.
Tbh this is probably revealing of the issue of relying on .env files. If you could get #755 done, a lot of your problems would be fixed.
|
Straight up forgot about this for a hot minute lol @leonm1 these changes look good? |
Summary
Moving sentry url from strings.json to environment variable after I had been unknowingly spamming vaken status for the past month and a half.
Changes GCP bucket template string into one-liner as per README
Remove contributoors, replace with VandyHacks
Review Focus
Anything you want the reviewer to pay attention to? Feel free to delete this section.