more null-element fixes for Array<ToT> ops
#510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gaudel some places need clone since Tensor is shallow-copy
…sparse tile unit tests
evaleev
force-pushed
the
evaleev/fix/ToT-null-elements
branch
from
30e315d to
1efccd5
Compare
…ot know how to show boost::small_vector
evaleev
force-pushed
the
evaleev/fix/ToT-null-elements
branch
from
63c64f7 to
f851427
Compare
…h -DTA_TENSOR_ASSERT_NO_MUTABLE_OPS_WHILE_SHARED=ON , this will assert that mutating operations (*_to and inplace_*) do not act on shared objects
…217229a9ca39865cR423 and 42578f7#diff-c736976129e0dac73b903e29223540155efcecdcd45322a3217229a9ca39865cR423-R431 since op(a,b,c,...) may produce nonnull even if some of a,b,c,... are null for many types of op (e.g. add, subt)
…7229a9ca39865cR1002 to move empty checks inside tensor_reduce + add notes
evaleev
force-pushed
the
evaleev/fix/ToT-null-elements
branch
from
f851427 to
b7bb7e1
Compare
… accept rvalue refs for optimization
these are along the lines of some changes in UnaryWrapper in f70c004
evaleev
force-pushed
the
evaleev/fix/ToT-null-elements
branch
from
ad94164 to
ecf2e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.