Skip to content

restore the pre-fence introduced in #500 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evaleev merged 1 commit into from
Mar 8, 2025
Merged

restore the pre-fence introduced in #500 #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/TiledArray/einsum/tiledarray.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,12 @@ template <DeNest DeNestFlag = DeNest::False, typename ArrayA_, typename ArrayB_,
auto einsum(expressions::TsrExpr<ArrayA_> A, expressions::TsrExpr<ArrayB_> B,
std::tuple<Einsum::Index<std::string>, Indices...> cs,
World &world) {
// hotfix: process all preceding tasks before entering this code with many
// blocking calls
// TODO figure out why having free threads left after blocking MPI split
// still not enough to ensure progress
world.gop.fence();

using ArrayA = std::remove_cv_t<ArrayA_>;
using ArrayB = std::remove_cv_t<ArrayB_>;

Expand Down