Fix shell injection vulnerability in test_export_python.cpp #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
force-pushed
the
feature/export-numpy
branch
from
54556c0 to
1f3c2e6
Compare
Co-authored-by: Copilot <[email protected]>
Implement proper POSIX shell escaping for script path using single quotes. This prevents command injection when the path contains special shell metacharacters like backticks, dollar signs, or spaces. Co-authored-by: evaleev <[email protected]>
evaleev
force-pushed
the
feature/export-numpy
branch
from
cbe70f5 to
b11a07b
Compare
Co-authored-by: evaleev <[email protected]>
The CodeQL checker created build artifacts that should not be committed. Added _codeql_build_dir and _codeql_detected_source_root to .gitignore. Co-authored-by: evaleev <[email protected]>
Copilot
AI
changed the title
[WIP] Update minimal NumPy support based on review feedback
Fix shell injection vulnerability in test_export_python.cpp
Nov 21, 2025
evaleev
approved these changes
Nov 21, 2025
evaleev
force-pushed
the
copilot/sub-pr-429
branch
from
8bc0f5f to
13c0c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses shell escaping vulnerability identified in PR #429 review. The script path argument to
popen()was wrapped in double quotes, which doesn't protect against special shell metacharacters like backticks, dollar signs, or embedded quotes.Changes
shell_escape()helper function implementing POSIX single-quote escapingrun_python_code()to use proper escaping_codeql_build_dirand_codeql_detected_source_rootto.gitignoreImplementation
Before:
After:
The
shell_escape()function wraps arguments in single quotes and escapes embedded single quotes using'\''pattern, preventing command injection regardless of path contents.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.