Extend overloads for arithmetic operators of ExprPtr
#452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
approved these changes
Dec 11, 2025
Collaborator
Krzmbrzl
left a comment
Krzmbrzl
left a comment
There was a problem hiding this comment.
Maybe we could take the chance and extend Variable's ctor such that it can be constructed from a regular (UTF-8) string and then extend the test cases to include a version that uses an arithmetic operator with a UTF-8 string
Member
|
User defined literals seem a match made in heaven for this feature. Binary operation between plain strings and expression objects sounds a little risky to me. Update: meant |
char/wchar types were hitting this ctor, for example in expr + L"w" case
ajay-mk
force-pushed
the
ajay/feature/arithmetic-ops-with-variables
branch
from
8fc2cdb to
b13233f
Compare
Member
Author
|
The aim is to build expressions where the code reads like the equations. A user-defined literal would get in the way of that. For example, for |
Member
Author
|
Is this okay to merge? |
ajay-mk
added a commit
that referenced
this pull request
Dec 15, 2025
This requires changes from #452
ajay-mk
added a commit
that referenced
this pull request
Dec 16, 2025
This requires changes from #452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further extension of #450: adds operator overloads for
Variable, similar to the existing pattern forConstant.