fix(slides): stop rename input clipping, add cancel, shrink header bu… - #2223
Open
samark231 wants to merge 1 commit into
Open
fix(slides): stop rename input clipping, add cancel, shrink header bu…#2223samark231 wants to merge 1 commit into
samark231 wants to merge 1 commit into
Conversation
Deploying frontend-admin-dashboard with
|
| Latest commit: |
5b4b84e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://75a167f9.frontend-admin-dashboard.pages.dev |
| Branch Preview URL: | https://fix-slide-title-rename-heade.frontend-admin-dashboard.pages.dev |
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Renaming a slide from the study-library header was effectively unusable: the title
input overflowed its container and spilled off the left edge into a clipped region,
and the confirm tick rendered underneath the download button. There was also no way
to abandon a rename once started.
Frontend:
w-fitwith nomin-w-0,so flexbox refused to shrink it below an
<input>'s ~20-character min-contentfloor; now
min-w-0 flex-1. Droppedjustify-center, which was splitting theoverflow to both sides and pushing text off the left edge, where the ancestor's
overflow-x-hiddenclipped it unreachably.MyButtonwithshrink-0, so they can't be collapsed tozero width or painted over by the later-in-DOM actions row. Adds a real 24px hit
area,
type="button", andaria-label— the old bare<Check>icon had none.the only exit from edit mode was committing the change.
icon-only (they already carried
titletooltips), and Save Draft / Publish /Unpublish / Edit Link drop the
sm:min-w-36144px floor viasm:min-w-0, sothey size to their text.
Related Issue
Type of Change
How Has This Been Tested?
tsc --noEmitpasses clean across all three changed files.scripts/design-lint.mjsreports no findings in any changed region (pre-existingfindings elsewhere in these files are untouched).
no clipping at the left edge.
Checklist