fix(notification): SES verification identity/message mismatch + reset on address change - #2165
Open
neerajhariyale wants to merge 1 commit into
Open
fix(notification): SES verification identity/message mismatch + reset on address change#2165neerajhariyale wants to merge 1 commit into
neerajhariyale wants to merge 1 commit into
Conversation
…verification on address change Two bugs in SES sender verification that caused a confusing from-address vs verified-identity mismatch in the admin Email settings: 1. getStatus built its message from the from-address (email) instead of the address AWS actually verified (identity), so after changing the sender the UI said 'AWS sent a confirmation email to <from-address>' when it really went to the previously-submitted identity. Use identity for the message. 2. Changing the from-address left the old verification_identity/status intact, so the from-address and verified identity silently drifted (verified badge for the wrong address; sending falls back to the platform default). Reset the verification fields when the from-address changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs
In the admin Notification Settings → Email SES sender verification:
getStatusbuilt its message from the from-address (email) instead of the identity AWS actually verified. After the sender was edited, the UI showed "AWS sent a confirmation email to " when it really went to the previously-submitted identity — the exact mismatch that caused confusion in testing.updateEmailConfiguration) left the oldverification_identity/verification_statusin place, so the two silently diverged — a verified/pending badge would show for a different address than the one mail sends from, and sending would fall back to the platform default.Fix
EmailSenderVerificationService.getStatus→ message usesidentity(and its domain), notemail.EmailConfigurationService.updateEmailConfiguration→ when the from-address actually changes, resetverification_status/verified/verification_identity/verified_atso a fresh Verify sender re-establishes it for the new address.Verify
mvn -o compile→ 0 compilation errors. Merging auto-deploys (change undernotification_service/**matches the deploy workflow's push path filter).🤖 Generated with Claude Code