Skip to content

ci(electron-ota): publish with GH_ACTION_TOKEN #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neerajhariyale wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(electron-ota): publish with GH_ACTION_TOKEN #2139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/electron-ota-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ name: Build & Publish Electron OTA Update (NSIS + portable)
# collide with the existing one and clients won't see an update.
#
# TOKEN: publishing lands in a DIFFERENT repo (electron-build-repo), so the
# default GITHUB_TOKEN (scoped to this repo) is not enough. Provide a PAT with
# `contents:write` on Vacademy-io/electron-build-repo as the repo/org secret
# ELECTRON_PUBLISH_TOKEN.
# default GITHUB_TOKEN (scoped to this repo) is not enough. This uses the
# existing GH_ACTION_TOKEN secret (a cross-repo PAT). If that token lacks
# `contents:write` on Vacademy-io/electron-build-repo, the publish step fails
# with an auth error — swap in a token that has it.

run-name: "electron-ota-build ${{ inputs.flavor }} v${{ inputs.version_note }}"

Expand Down Expand Up @@ -92,8 +93,10 @@ jobs:
- name: Build & publish OTA update
working-directory: ./frontend-learner-dashboard-app/electron
env:
# PAT with contents:write on Vacademy-io/electron-build-repo (cross-repo publish).
GH_TOKEN: ${{ secrets.ELECTRON_PUBLISH_TOKEN }}
# Cross-repo publish to Vacademy-io/electron-build-repo. Uses the existing
# GH_ACTION_TOKEN secret (the account running this repo has pull-only access
# to electron-build-repo, so a personal PAT can't publish there).
GH_TOKEN: ${{ secrets.GH_ACTION_TOKEN }}
run: npx electron-builder build --win -c ./electron-builder.${{ inputs.flavor }}.json --publish always

- name: Upload build artifacts (installer + update manifest)
Expand Down
Loading