Devops/render worker ghactions deploy - #1867
Open
shreyash-jain wants to merge 6 commits into
Open
Conversation
The standalone build host (157.90.162.154) was decommissioned. New deploy flow: - GH-hosted runner builds the image (build.sh --context-only + buildx) - Pushes ghcr.io/vacademy-io/render-worker:v<date>-<sha> + :latest - kubectl set image rolls the new tag onto the k3s Deployment - Smoke-tests /health via cluster DNS from ai-service pod deploy.sh becomes a thin 'gh workflow run' wrapper with: - Detached-HEAD guard - Pre-flight check that the ref exists on origin - Warning when working tree is dirty or local is ahead of origin - Timestamp-based run resolution (no race against prior runs); 10s safety margin for clock skew - --help output bounded by heavy banner rules so it doesn't leak code Triggers: workflow_dispatch + push to main when render_worker or ai-video-gen-main code changes. Three rounds of adversarial review caught a race condition, a help-output sed-range bug, and a few minor concerns. All addressed before commit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The callback redirected with a generic ?zoom_error=connect_failed, forcing a per-pod log hunt to find the cause. Append &zoom_reason=<message> (URL-encoded, truncated, no secrets) so the failure is visible in the browser URL. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
getMe swallowed the Zoom response and returned null, so a missing-scope failure showed only as the generic 'Could not read the connected Zoom user profile'. Now it propagates Zoom's status + body (e.g. code 4711 'does not contain scopes:[user:read]'), which the callback puts in the redirect URL — pinpointing exactly which scope to grant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
getZakToken logged only the exception class, so a missing-scope ZAK failure (which leaves host/role=1 unable to start the meeting) was invisible. Log Zoom's status + body so e.g. 'does not contain scopes:[user_zak:read]' is clear. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related Issue
Type of Change
How Has This Been Tested?
Checklist