Skip to content

fix: add logic to end the trigger when is_end_node field of workflow_… #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samark231 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add logic to end the trigger when is_end_node field of workflow_… #1818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .../java/vacademy/io/admin_core_service/features/workflow/service/WorkflowEngineService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,19 @@ public Map<String, Object> run(String workflowId, Map<String, Object> seedContex
"node.type", nodeType, "layer", "2-workflow-engine"));
}

// is_end_node terminates ONLY this branch — not the entire workflow.
// Other paths already on the execution stack (from multi-goto fan-out
// or diamond DAGs) will still run. The handler above has already
// executed for this node, so any final side-effects (e.g. a closing
// SEND_EMAIL or UPDATE_RECORD) are honored before the path ends.
// To stop a whole workflow run, every terminal leaf must be marked
// is_end_node = true.
if (Boolean.TRUE.equals(current.getIsEndNode())) {
log.info("Node {} has is_end_node=true — terminating this path (other branches, if any, continue)",
current.getId());
continue;
}

// Evaluate routing to find next nodes and push them to stack
List<String> nextNodeIds = evaluateRoutingNextNodeIds(effectiveConfig, ctx);
log.info("Routing evaluation for node {} returned: {}", current.getId(), nextNodeIds);
Expand Down