feat: add rate limiting to auth service login endpoints - #1210
Open
Mrsandeep27 wants to merge 9418 commits into
Open
feat: add rate limiting to auth service login endpoints#1210Mrsandeep27 wants to merge 9418 commits into
Mrsandeep27 wants to merge 9418 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1199
RateLimitingFilterextendingOncePerRequestFilterfor login endpoint protectionRetry-Afterheader when limit exceeded/login-root,/login-otp,/login-whatsapp-otp,/request-otp,/request-whatsapp-otp,/verify-generic-whatsapp-otp-loginX-Forwarded-Forfor correct IP detection behind nginx/load balancerConcurrentHashMap+AtomicInteger)Test plan
/auth-service/v1/login-rootand verify 429 on 6thRetry-Afterheader is present in 429 responseGenerated with Claude Code