Skip to content

Make prettier more compatible with yamlfix #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 4 commits into from
Jan 3, 2026
Merged

Make prettier more compatible with yamlfix #2824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd4cd4e
Make prettier more compatible with yamlfix
adamtheturtle Jan 3, 2026
7b8efd4
Add zizmor
adamtheturtle Jan 3, 2026
238737c
Fix prettier
adamtheturtle Jan 3, 2026
694ce56
Fix zizmor
adamtheturtle Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---

name: Build Docker images

# This matches the Docker image building done in the release process.
Expand All @@ -17,6 +16,8 @@ on:
- cron: 0 1 * * *
workflow_dispatch: {}

permissions: {}

jobs:
build:
name: Build Docker images
Expand All @@ -31,6 +32,8 @@ jobs:

steps:
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---

name: Lint

on:
Expand All @@ -13,9 +12,10 @@ on:
- cron: 0 1 * * *
workflow_dispatch: {}

permissions: {}

jobs:
build:

strategy:
matrix:
python-version: ['3.13']
Expand All @@ -25,6 +25,8 @@ jobs:

steps:
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Install uv
uses: astral-sh/setup-uv@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---

name: Release

on: workflow_dispatch
Expand Down Expand Up @@ -29,6 +28,7 @@ jobs:
# Also, avoids
# https://github.com/stefanzweifel/git-auto-commit-action/issues/99.
fetch-depth: 0
persist-credentials: false
Copy link

@cursor cursor bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

persist-credentials breaks git-auto-commit push in release workflow

Adding persist-credentials: false to the checkout step removes git credentials after checkout. The release workflow uses stefanzweifel/git-auto-commit-action@v7 at line 70 to push changelog commits back to the repository. Without persisted credentials, this action will fail to authenticate when pushing, completely breaking the release process. The workflow comments explicitly reference this action, confirming the dependency on git push capability.

Fix in Cursor Fix in Web


- name: Install uv
uses: astral-sh/setup-uv@v7
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ on:
# workflows. We therefore want to run only one workflow at a time.
concurrency: vuforia_credentials

permissions: {}

jobs:
# CI tests with matrix
ci-tests:
Expand Down Expand Up @@ -117,6 +119,8 @@ jobs:

steps:
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Install uv
uses: astral-sh/setup-uv@v7
Expand Down Expand Up @@ -186,6 +190,8 @@ jobs:

steps:
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Install uv
uses: astral-sh/setup-uv@v7
Expand Down Expand Up @@ -229,6 +235,8 @@ jobs:

steps:
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Install uv
uses: astral-sh/setup-uv@v7
Expand Down Expand Up @@ -269,6 +277,8 @@ jobs:

steps:
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Install uv
uses: astral-sh/setup-uv@v7
Expand Down
3 changes: 2 additions & 1 deletion .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
{
"files": ["*.yaml", "*.yml"],
"options": {
"singleQuote": true
"singleQuote": true,
"printWidth": 100
}
}
]
Expand Down
12 changes: 12 additions & 0 deletions zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
rules:
unpinned-uses:
disable: true
cache-poisoning:
disable: true
bot-conditions:
disable: true
dependabot-cooldown:
disable: true
template-injection:
disable: true