-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs based on BTD and deployed with CI #1
base: master
Are you sure you want to change the base?
Conversation
It sounds very good indeed. Thanks for having a go at this!
I'm not sure about this. I think it would be cleaner to keep the exercises in the tutorial subdir for now.
There won't be any specific tutorial about CI, for now. The current workflow is a showcase of CI procedures (https://github.com/VUnit/tdd-intro/blob/master/.github/workflows/tests.yml) and there is content in http://vunit.github.io/blog/2020_08_12_continuous_integration_with_vunit_action_in_10_lines_of_code.html and http://vunit.github.io/ci/intro.html (referenced in the README here). We might enhance that documentation and/or the workflow, but I don't think there are more sources to be added in that regard.
Maybe the other way? Just remove the original subdir.
Will you move the markdown sources somewhere else or will you keep each one in the corresponding subdir?
I think it's good to push to branch Actually, you can use the BTD Action for that:
With regard to the engine, some years ago I wrote a shell script for generating a PDF using pandoc. I pushed that branch some minutes ago: https://github.com/VUnit/tdd-intro/tree/umarcor/tutorial-pdf-pandoc. Nevertheless, I think it is desirable to use Sphinx, as you said. It will provide HTML and PDF outputs, along with better integration with other projects/repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Maybe this PR should target branch 'tutorial', instead of 'master'. Alternatively, we might merge branch tutorial into master as-is, and then rebase this. @LarsAsplund what do you think?
- @rodrigomelo9 I did not find in the
conf.py
any statement to tell sphinx were to find the markdown sources. Did you implement that?
Ok @umarcor I will apply your suggestions. Regarding the current doc under tutorial, My idea is:
Do you prefer to maintain as Markdown? Is ok to move them to |
With regard to changing from markdown to restructuredtext, I do think that is desirable indeed. |
bee824d
to
879a300
Compare
f0f6093
to
7bce270
Compare
@rodrigomelo9 this PR seems to contain a single commit now. Is that correct? |
Yes, a single commit. I applied several of your simplest reviews and then, I forced a push. |
In this PR I will solve to have the docs generated with BTD in CI. |
7bce270
to
9809344
Compare
41f18c5
to
b42b9cb
Compare
b42b9cb
to
5014a79
Compare
5014a79
to
54ac914
Compare
5e9f9cc
to
003277a
Compare
003277a
to
f8993ca
Compare
f8993ca
to
dabd278
Compare
@LarsAsplund @umarcor
Months ago, Lars added a tutorial. I know that the idea was to have material for this repo, but not sure about the details. I want to contribute. I added the needed to generate docs. Let me know if the following is useful for you and details such as names/paths:
tutorial/exercise_0*
totdd/excercise_0x
.tdd
assuming there will beci
. I am ok? there will be a tutorial for TDD and another for CI?original
andsolution
inside eachtdd/excercise_0x
.src
andtest
are insideoriginal
and not needed for separate in a repo.instructions.html
(will be generated in the sphinx doc) and I will convertinstructions.md
intotdd_0x.md
(one per exercise). I will adddocs.yml
for CI (where the doc must be deployed @umarcor?).Sound good?