allow setting negative numbers to ignore stack limit #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Motive for This Pull Request
Had an issue where items were not added because limit was set to -1 (we want weight limit to determine how much you can carry for most items)
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
Allow limit to be set to -1 and allow to ignore stack limit when adding item.
Explain the necessity of these changes and how they will impact the framework or its users.
No real impact except more customization
Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests.
Set item limit to -1 in DB for item
Try to add -1 item
All is triggered but item count does not update
After
Repeat but the item count will go up