Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting negative numbers to ignore stack limit #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dexslab
Copy link

@dexslab dexslab commented Mar 13, 2025

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motive for This Pull Request

Had an issue where items were not added because limit was set to -1 (we want weight limit to determine how much you can carry for most items)

Provide a brief explanation of why these changes are being proposed and what they aim to achieve.

Allow limit to be set to -1 and allow to ignore stack limit when adding item.

Explain the necessity of these changes and how they will impact the framework or its users.

No real impact except more customization

Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests.

Set item limit to -1 in DB for item
Try to add -1 item
All is triggered but item count does not update

After
Repeat but the item count will go up

  • [X ] Tested with latest vorp scripts
  • Tested with latest artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant