-
Notifications
You must be signed in to change notification settings - Fork 351
fix: 文の途中から連続再生した際、次以降の文が途中から再生される問題を修正 #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: 文の途中から連続再生した際、次以降の文が途中から再生される問題を修正 #2872
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
sevenc-nanashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
特に問題なさそう。
動作確認したらマージします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes issue #2634 where continuous playback starting from the middle of a sentence would cause subsequent sentences to also start playing from the same offset position instead of from the beginning. The fix resets the audio play start point to undefined (which means play from the beginning) when transitioning to a different audio item during continuous playback.
Key changes:
- Added logic to reset the play start point when the audio key changes during continuous playback
- The original play start point is preserved and restored after continuous playback completes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (currentAudioKey !== e.audioKey) { | ||
| mutations.SET_AUDIO_PLAY_START_POINT({ startPoint: undefined }); | ||
| } |
Copilot
AI
Dec 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic to reset the audio play start point appears in both the playAudioBlob callback and the waitstart event listener. This creates redundancy since playstart (which calls playAudioBlob) always follows waitstart in the event flow. Consider removing the duplicate logic from one of these locations to improve maintainability. The reset in playAudioBlob should be sufficient since it's called whenever audio starts playing.
| if (currentAudioKey !== e.audioKey) { | |
| mutations.SET_AUDIO_PLAY_START_POINT({ startPoint: undefined }); | |
| } |
内容
文の途中から連続再生すると、次以降の文も途中から再生される問題を修正します。
本修正により、次以降の文は常に文頭から再生されます。
関連 Issue
close #2634
スクリーンショット・動画など
その他