Skip to content

Conversation

@Hiroshiba
Copy link
Member

内容

音声書き出し時のダイアログ表示部分を共通化しました。
ショートカットキー呼び出し時とツールバーのボタンから実行したときで同じロジックが実装されていた感じだったので。

その他

↓のプルリクの変更が大きくなってきたので、少しでも減らせればと思って切り出してみました

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the audio export dialog display functionality by consolidating duplicate logic. Previously, the same dialog logic was implemented in both shortcut key calls and toolbar button executions, which has now been centralized into common store actions.

  • Removed direct dialog function imports and calls from ToolBar.vue
  • Replaced inline dialog logic with centralized store actions
  • Simplified three audio generation functions to use new store actions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:56cde12

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそう。

@sevenc-nanashi
Copy link
Member

マージします。

@sevenc-nanashi sevenc-nanashi added this pull request to the merge queue Sep 27, 2025
Merged via the queue into VOICEVOX:main with commit 858a6ca Sep 27, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the refactor--音声書き出し時のダイアログ表示部分を共通化 branch October 4, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants