refactor: プロジェクト保存周りの関数を別ファイルに切り出してリファクタリング #2573
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
…ルを保存する関数をユースケースに応じて３つに分割
|
いけてそうだったのでdraft開けました！！ |
There was a problem hiding this comment.
PR Overview
This PR refactors the project saving functionality by extracting related functions into a dedicated helper file and reorganizing store actions and types to remove conditionals and improve clarity.
- Separates the SAVE_PROJECT_* use cases into distinct functions in saveProjectHelper.ts
- Introduces showErrorDialog for common error display and simplifies error message handling in ResultError
- Updates store directories and action names for improved maintainability and consistency
Reviewed Changes
| File | Description |
|---|---|
| src/store/project/saveProjectHelper.ts | New helper functions for project saving logic |
| src/store/project/index.ts | Store actions now reference the new helper functions and updated action names |
| src/components/Dialog/Dialog.ts | Adds an exported showErrorDialog for handling error display |
| src/type/result.ts | Modifies ResultError to use only the result code in the error message for brevity |
| src/store/type.ts | Updates and adds TypeScript types for actions and action context |
| src/components/Talk/ToolBar.vue | Updates store actions calls to match the new action names |
| src/components/Menu/MenuBar/MenuBar.vue | Updates store actions calls to match the refactored action names |
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
|
|
||
| constructor(public readonly result: FailureResult<E>) { | ||
| super(`${result.code}: ${result.error.message}`, { cause: result.error }); | ||
| super(`${result.code}`, { cause: result.error }); |
There was a problem hiding this comment.
ResultError now only includes the result code in its error message, which may reduce debugging clarity. Consider including additional error detail or the original message to aid in troubleshooting.
| super(`${result.code}`, { cause: result.error }); | |
| super(`${result.code}: ${result.error.message}`, { cause: result.error }); |
There was a problem hiding this comment.
ごもっともなんだけど、errorToMessage関数に投げることを考えると、result.error.messageはcause: error側でも現れるから、ここはエラーコードだけをメッセージにするのが良いかなぁと。
…ルを保存する関数をユースケースに応じて３つに分割
|
レビューありがとうございます、マージします！！ これでstoreの関数を外に書き出しやすくなる！！！！ |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 participants
内容
タイトルのとおりです。
store/project.tsをstore/project/index.tsに移動し、ついでに関数をファイル切り出しします。このPRには提案が３つ含まれてます：
SAVE_PROJECT_*系３つのユースケースを別々に関数に分け、if分岐をなくすリファクタリングshowErrorDialog関数その他
エラーメッセージはこんな感じ