linter: mask filtering rules path #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidanio
force-pushed
the
hidanio/mask_filtering_rules_path
branch
from
6b849aa to
4fe6e2c
Compare
|
|
||
| for { | ||
| i++ | ||
| if i >= len(parts) { |
There was a problem hiding this comment.
you don't change the parts, why calculate its length every time?
| @@ -1526,21 +1526,79 @@ func IsRuleEnabledForPath(root *RuleNode, filePath string, checkRule string) boo | |||
| // Starting with global state. We have guarantee while parsing config that rule is `on` and exist | |||
| ruleState := true | |||
|
|
|||
| for _, part := range parts { | |||
There was a problem hiding this comment.
in go for-range returns the index and the value of the elements in each index. Are you sure you should have changed it to for-loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.