Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic rules: paths grouping #1242

Merged
merged 9 commits into from
Feb 1, 2025
Merged

Conversation

Hidanio
Copy link
Contributor

@Hidanio Hidanio commented Jan 23, 2025

It would be convenient to group a list of paths so that the rules are more compact.


/**
 * @path-group-name GROUP1 <- something like id for group
 * @path VK/Connect <- path in GROUP1
 * @path ... <- another path in GROUP1
 */

/**
 * @path-group GROUP1
 * @warning please, use AppFacade::getApp() in GROUP1 code
 */
getApp();

/**
 * @path /
 * @path-group-exclude GROUP1
 * @warning please, use getApp() outside GROUP1 code
 */
AppFacade::getApp();

/**
 * @path-group GROUP1
 * @path-exlude TestApp/Connect/Apps
 * @warning please, use AppFacade::getApp() in GROUP1 code
 */
rpcCall(CLUSTER_APPLICATIONS); 

@Hidanio Hidanio added enhancement New feature or request dynamic-rules Related to dynamic rules support labels Jan 23, 2025
@Hidanio Hidanio self-assigned this Jan 23, 2025
@Hidanio Hidanio changed the title dynamic rules: path grouping dynamic rules: paths grouping Jan 23, 2025
@Hidanio Hidanio marked this pull request as ready for review January 28, 2025 23:14
@Hidanio Hidanio added the documentation Improvements or additions to documentation label Jan 31, 2025
@Hidanio Hidanio force-pushed the hidanio/path_groups_dynamic_rules branch from 0d6ef27 to 27a3f5e Compare January 31, 2025 22:34
@Hidanio Hidanio merged commit 984a729 into master Feb 1, 2025
4 checks passed
@Hidanio Hidanio deleted the hidanio/path_groups_dynamic_rules branch February 1, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation dynamic-rules Related to dynamic rules support enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant