apply updated code style #1196
apply updated code style #1196
Conversation
.git-blame-ignore-revs
Outdated
There was a problem hiding this comment.
after squash, there will be another sha commit. .git-blame-ignore-revs should be added after the merge of this MR
There was a problem hiding this comment.
Yes, it's added here so you can test it and make sure that git blame continues working
| @@ -3,12 +3,12 @@ | |||
| #include "common/smart_ptrs/intrusive_ptr.h" | |||
|
|
|||
| #ifndef INCLUDED_FROM_KPHP_CORE | |||
| #error "this file must be included only from runtime-core.h" | |||
| #error "this file must be included only from runtime-core.h" | |||
There was a problem hiding this comment.
don't want to enable `IndentPPDirectives'?
There was a problem hiding this comment.
+1 for macro indentation
| AllowAllParametersOfDeclarationOnNextLine: true | ||
| AllowShortBlocksOnASingleLine: false | ||
| AllowShortCaseLabelsOnASingleLine: false | ||
| AllowShortFunctionsOnASingleLine: Empty |
There was a problem hiding this comment.
maybe we should keep it?
| ReflowComments: true | ||
| SortIncludes: true | ||
| SpaceAfterCStyleCast: false | ||
| SpaceAfterTemplateKeyword: false |
There was a problem hiding this comment.
Includes are sorted implicitly by setting base variant on LLVM, I suppose.
| IncludeCategories: | ||
| - Regex: '^<' | ||
| Priority: 1 | ||
| IndentCaseLabels: true |
There was a problem hiding this comment.
maybe we should keep it?
There was a problem hiding this comment.
Mb will we add the formatting script first, and then the new rules?
| @@ -3,12 +3,12 @@ | |||
| #include "common/smart_ptrs/intrusive_ptr.h" | |||
|
|
|||
| #ifndef INCLUDED_FROM_KPHP_CORE | |||
| #error "this file must be included only from runtime-core.h" | |||
| #error "this file must be included only from runtime-core.h" | |||
There was a problem hiding this comment.
+1 for macro indentation
| ReflowComments: true | ||
| SortIncludes: true | ||
| SpaceAfterCStyleCast: false | ||
| SpaceAfterTemplateKeyword: false |
There was a problem hiding this comment.
Includes are sorted implicitly by setting base variant on LLVM, I suppose.
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
3736a14 to
6fcdf6f
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
2 times, most recently
from
3418219 to
fa623c6
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
fa623c6 to
e2ff8dc
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
03adca9 to
d113357
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
2 times, most recently
from
eb36bfa to
4e20e4f
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
9 times, most recently
from
f17d303 to
948eec1
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
948eec1 to
9d63b68
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
1543212 to
3286da4
Compare
| contents: read | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
I would add a paths section and specify the paths to the folders where we want to check the new code.
There was a problem hiding this comment.
Just in case.
This will need to be put in another MR so that after adding the MR to .git-blame-ignore-revs we don't lose its history.
| @@ -0,0 +1,41 @@ | |||
| name: "Check code formatting" | |||
|
|
|||
| permissions: | |||
| - name: Check for formatting changes | ||
| run: | | ||
| # Check if any files were modified by clang-format | ||
| git diff --exit-code |
There was a problem hiding this comment.
It can be shortened to:
git diff --exit-code || ( echo "Code is not formatted. Please run clang-format." && exit 1 )
:)
No description provided.