Di/ios provider/file and logs/qa 16207 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2025 23:33
irdkwmnsb
reviewed
Feb 11, 2025
| const realGroup = await group.get() | ||
| const parser = new IncompleteJsonParser() | ||
|
|
||
| DeviceLogger.stream = spawn('idb', ['log', '--udid', options.serial, '--', '--style', 'json']) |
There was a problem hiding this comment.
--style json is unrecognized on an iphone with ios 18.1.1 and idb-companion 1.1.8
Co-authored-by: Maxim <[email protected]>
…-16207' into di/ios-provider/file-and-logs/QA-16207
irdkwmnsb
approved these changes
Feb 13, 2025
| @@ -82,7 +87,7 @@ export default syrup.serial() | |||
| realGroup.group | |||
| , wireutil.envelope(new wire.DeviceLogcatEntryMessage( | |||
| options.serial | |||
| , new Date().getTime() / 1000 | |||
| , Date.parse(timestamp) / 1000 | |||
There was a problem hiding this comment.
Default value of timestamp in case no timestamp could be found from the log line entry is not parseable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ios filesystem and ios logs (with filters)