Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech(storybook): add storybook addon documentation link button #8259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Release notes

Описание

Сейчас со страницы компонента в styleguide можно перейти на страницу компонента в storybook, а наоборот сделать не получится. Нужно добавить кнопку для перехода в styleguide

Изменения

  • Добавил аддон, который добавляет кнопку с помощью которой можно перейти на страницу с докой по компоненту
  • Поскольку не все компоненты из сторибука имеют отдельную страницу в доке, на этапе сборки добавил получение конфига для styleguide-а, откуда вытаскиваю список компонентов. И уже в зависимости от того, есть ли компонент в списке, показываю кнопку для перехода к доке
  • Получение базовой ссылки на доку сделал через вытаскивание из package.json ссылки на homepage
  • Также переделал получение ссылки на репозиторий проекта, через парсинг package.json

Release notes

Документация

  • в storybook добавлена возможность перейти к странице с документацией компонента в styleguide

@EldarMuhamethanov EldarMuhamethanov added this to the v7.2.0 milestone Feb 11, 2025
@EldarMuhamethanov EldarMuhamethanov self-assigned this Feb 11, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner February 11, 2025 09:56
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

👀 Docs deployed

Commit 85be33a

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (d3f5e1c) to head (85be33a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8259   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         404      404           
  Lines       11559    11559           
  Branches     3837     3837           
=======================================
  Hits        11043    11043           
  Misses        516      516           
Flag Coverage Δ
unittests 95.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

шикарно!!! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants