Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HorizontalScroll, CardScroll): fix rtl view #8110

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(HorizontalScroll, CardScroll): fix rtl view #8110

wants to merge 6 commits into from

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компонент HorizontalScroll работает неправильно в rtl, а с ним вместе соответственно компонент CardScroll тоже работает некорректно

Изменения

  • Доработана логика компонента HorizontalScroll в режиме rtl
  • Доработана логика компонента CardScroll в режиме rtl

Release notes

Улучшения

  • HorizontalScroll: Добавлена поддержка rtl
  • CardScroll: Добавлена поддержка rtl

@EldarMuhamethanov EldarMuhamethanov added this to the v7.2.0 milestone Dec 19, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 19, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 19, 2024 13:25
@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft December 19, 2024 13:25
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 396.69 KB (+0.09% 🔺)
JS (gzip) 120.52 KB (+0.12% 🔺)
JS (brotli) 99.06 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.39 KB (+0.08% 🔺)
CSS (gzip) 43.14 KB (+0.1% 🔺)
CSS (brotli) 34.45 KB (+0.01% 🔺)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

👀 Docs deployed

Commit e876349

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.55%. Comparing base (59c9515) to head (e876349).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ages/vkui/src/components/CardScroll/CardScroll.tsx 82.60% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8110      +/-   ##
==========================================
+ Coverage   95.54%   95.55%   +0.01%     
==========================================
  Files         404      404              
  Lines       11605    11635      +30     
  Branches     3853     3868      +15     
==========================================
+ Hits        11088    11118      +30     
  Misses        517      517
Flag Coverage Δ
unittests 95.55% <90.24%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 3, 2025
@vkcom-publisher
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 18, 2025
@vkcom-publisher
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 27, 2025
@EldarMuhamethanov
Merge branch 'master' into e.muhamethanov/rtl/HorizontalScroll
0b4c633 
# Conflicts:
#	packages/vkui/src/components/CardScroll/CardScroll.test.tsx
#	packages/vkui/src/components/CardScroll/CardScroll.tsx
#	packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
@EldarMuhamethanov
test(CardScroll): fix tests
46140bb
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Feb 8, 2025
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Feb 12, 2025
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review February 12, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:card-scroll cmp:horizontal-scroll type:feature
Projects
VKUI
Status: 👀 In Review
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EldarMuhamethanov @vkcom-publisher