icap-client: simplify ICAP connection pooling - #106
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
zh-jq
requested changes
Sep 16, 2026
| config: Arc<IcapServiceConfig>, | ||
| options: Arc<IcapServiceOptions>, | ||
| options: ArcSwap<IcapServiceOptions>, | ||
| idle_pool: Mutex<VecDeque<IdleIcapConnection>>, |
Contributor
There was a problem hiding this comment.
could this lock be sharded by worker id？ The similar has been done in site http1 connection poll(but not tested).
This will be a bottleneck when running with many cpu cores.
DanielHaimanot
force-pushed
the
icap_conn_pool
branch
from
September 17, 2026 00:00
0fc977c to
a43979a
Compare
zh-jq
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the ICAP connection pool to make reuse simpler.
Main changes:
No change to the proxy existing ICAP capability/OPTIONS semantics. Connection refill happens outside the idle pool lock.
Note: some test code was created with AI assistance and manually reviewed.