please review it. This is the image of changes which i have done in #40.#65
Open
anupriyajain595 wants to merge 14 commits intoUsmanAhmadSaeed:mainfrom
Open
please review it. This is the image of changes which i have done in #40.#65anupriyajain595 wants to merge 14 commits intoUsmanAhmadSaeed:mainfrom
anupriyajain595 wants to merge 14 commits intoUsmanAhmadSaeed:mainfrom
Conversation
anupriyajain595
commented
Oct 18, 2022
anupriyajain595
commented
…ue. Could you please review it?
Update style.css
Owner
|
@anupriyajain595 I'll review and update. |
Author
|
Okay sir |
Collaborator
|
Please read our rules and guidelines before adding an animation. Our rules specify that the animation has to be from pure HTML, CSS, JS and not any other framework but GSAP. You're using Typed. It would be a really good JavaScript challenge to remove the framework and try to recreate the same thing. |
Author
|
Sir i have removed the framework so please review it. |
Owner
|
@anupriyajain595 please add comments and follow coding best practices. Please take a look at all our guidelines before next commit. Also, I've added the hacktoberfest accepted label so don't worry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.