Adding a test using the formula #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for multi-group transition formulas in DEFM models, enabling specification of higher-order Markov processes (order > 1) using explicit bracketed notation. The changes include enhanced formula parsing, improved naming conventions, and comprehensive test coverage.
- Enhanced formula parsing to support both 2-group (backwards compatible) and m_order+1 group notation for transition effects
- Refactored motif naming logic to display each time point separately with consistent bracket notation
- Added validation logic and error checking for the new multi-group formula syntax
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/terms.cpp | Added type casting and validation for term counter |
| inst/tinytest/test_markov_two.R | New test validating order-2 Markov model with 3-group formula syntax |
| inst/tinytest/test_defm.R | Extended test comparing formula-based and matrix-based model specifications |
| inst/include/barry/models/defm/formula.hpp | Major enhancement to support multi-group transition formulas with explicit time point specification |
| inst/include/barry/models/defm/counters.hpp | Refactored motif naming to consistently show time points separately; fixed typo "ennumerated" → "enumerated" |
| Makefile | Added --delete flag to rsync for cleaner updates |
| .github/workflows/r.yml | Added valgrind check configuration to CI workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.