Conversation
Removed 'umap>=0.1.1' and added 'umap-learn==0.5.7' and 'llvmlite>=0.45.0' to dependencies.
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
danielrazavi
approved these changes
Feb 9, 2026
Member
danielrazavi
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Updating pyproject.toml to handle dependency conflicts + disabling GPU for tensorflow across all labs. Specifically updated UMAP and sklearn versions so they install correctly. Furthermore, I'm adding a code block to disable GPU if the participant has a GPU on their machine, along w/ comments saying they can disable it if they want.
NOTES ON GPU DISABLING: Keras/Tensorflow often has problems if someone hasn't install ptxas, the proper cuda versions, updated drivers, etc. Its easier and more practical to just add a code bit to disable GPU access unless someone's confident in enabling it.
FUTURE WORK: Tensorflow/keras is cool, but its so clunky. Maybe we can go full torch/skorch (https://github.com/skorch-dev/skorch) after this?
Checklist