Conversation
…e artifacts (see ISSUES_TO_FIX.md)
…e input_shape warning
…oad; add compute+cache; refactor compute_acc API + call sites; set loss_weights to [1.,10.]; remove symbolic tensor boolean check
…to remove convergence note
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the deep learning course materials for Cohort Seven by updating dates, contact information, lab structure, and fixing bugs across multiple labs. The changes consolidate the curriculum to 6 core labs, improve code reliability, and enhance the learning experience through dependency management and environment setup improvements.
Key Changes:
- Updated cohort-specific metadata (dates, contact info, Slack channels) from Cohort Six to Cohort Seven
- Fixed bugs in labs 1, 2, 5, and 6 to improve functionality and prevent warnings
- Added missing dependencies (h5py, tqdm, imageio, scikit-image) to pyproject.toml
- Migrated deprecated labs (8, 9, 10) to archived directory
Reviewed Changes
Copilot reviewed 13 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added missing dependencies required for labs |
| README.md | Updated dates, assessment structure, contact info, and cohort references |
| README.html | Applied same metadata updates as README.md |
| 04_cohort_six/additional_resources/labs/lab_*.ipynb | Deleted deprecated lab files (8, 9, 10) |
| 03_instructional_team/README.md | Updated session dates and cohort references |
| 02_activities/assignments/assignment_*.ipynb | Updated due dates, Slack channels, and submission requirements |
| 01_materials/labs/lab_6.ipynb | Increased LogisticRegression max_iter and removed convergence warning note |
| 01_materials/labs/lab_5.ipynb | Changed dataset URL, implemented local representation computing, adjusted loss_weights |
| 01_materials/labs/lab_2.ipynb | Added guard condition to prevent division by zero at step 0 |
| 01_materials/labs/lab_1.ipynb | Added explicit Input layer to follow Keras best practices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexwolson
left a comment
There was a problem hiding this comment.
Manually re-reviewed my changes on GitHub.
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
The code checks if values are None, not if names are undefined, so ValueError is semantically correct.
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
Migrate module setup to uv
Resolved conflicts: - .gitignore: Combined both sets of ignore rules - README.md: Updated to reference cohort_seven and included SETUP.md/pyproject.toml descriptions - pyproject.toml: Kept cohort_seven dependencies with additional packages from main - Directory structure: Kept 04_cohort_seven over 04_this_cohort naming convention
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
danielrazavi
left a comment
There was a problem hiding this comment.
The merging of the move_to_uv branch has caused this PR to go stale. @alexwolson no action needed from you, will make a new commit that will fix this PR. Stand by.
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
There was a problem hiding this comment.
Looks good to me now. @alexwolson can you please do one final review, and if its good, we'll merge it in.
|
Re-reviewed. All looks good to me. Thank you for your help @danielrazavi |
Cohort Seven Updates
Summary
This PR includes comprehensive updates to prepare the deep learning course materials for Cohort Seven. The changes encompass lab improvements, dependency management, repository structure reorganization, and the removal of deprecated materials.
Key Changes:
pyproject.tomland refresheduv.lock.gitignoreentries for large artifactsDetailed Changes
Bug Fixes & Lab Improvements
Lab 1: Keras Input Layer Warning Fix
input_shapeparameter in Dense layersInput(shape=...)layer before the first Dense layer01_materials/labs/lab_1.ipynbLab 2: Division by Zero Guard
if i > 0 and i % 100 == 0to skip logging at step 001_materials/labs/lab_2.ipynbLab 5: Major Refactoring
Multiple improvements to make the lab more robust and maintainable:
Dataset URL Migration
http://host.robots.ox.ac.uk/pascal/VOC/voc2007/VOCtrainval_06-Nov-2007.tarhttps://github.com/alexwolson/pascal-voc-2007-mirror/raw/main/VOCtrainval_06-Nov-2007.tar.gz.tarto.tar.gzRepresentation Computing
compute_accAPI refactoring for better maintainabilitytqdmfor batch processingvoc_representations.h5for reuseModel Training Parameters
loss_weightsto[1., 10.]for better class/bbox balanceCode Quality
01_materials/labs/lab_5.ipynbLab 6: Convergence Improvement
LogisticRegressionmax_iterfrom default to 100001_materials/labs/lab_6.ipynbDependency Management
pyproject.toml Updates
Added missing dependencies required by lab exercises:
uv.lock Refresh
Repository Structure & Cleanup
Cohort Directory Creation
04_cohort_seven/directory name04_cohort_seven/additional_resources/labs/for archived materialsDeprecated Lab Migration
Moved labs 8, 9, and 10 to archived locations:
01_materials/labs/lab_8.ipynb,lab_9.ipynb,lab_10.ipynb04_cohort_seven/additional_resources/labs/.gitignore Updates
Added entries for large artifacts that shouldn't be version controlled:
Documentation Updates
README.md
Instructional Team Documentation
03_instructional_team/README.mdAssignment Updates
Minor updates to assignments 1 and 2 to align with lab fixes
02_activities/assignments/assignment_1.ipynb,assignment_2.ipynb