Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to stop passing repository environment secrets into the Fly deployment GitHub Action, based on the assumption that Fly should source required configuration from its own secrets store.
Changes:
- Removed multiple
--build-arg ...=${{ secrets.* }}parameters from the frontendflyctl deploycommand in the workflow. - Left the deployment command as
flyctl deploy --remote-only --config fly.tomlfor the frontend job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harbassan
force-pushed
the
chore/rm_redundant_secrets
branch
from
e05069b to
c8c38fa
Compare
harbassan
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harbassan
force-pushed
the
chore/rm_redundant_secrets
branch
from
c8c38fa to
22d3dd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The gh deployment action sends a bunch of secrets (from the repo environment) to fly, and the naming is inconsistent.
Solution
Renamed the secrets in the gh environment and hence in the gh action.
Risk
The deployment might fail if I've messed something up