feat: add source permission metadata for google drive #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyanid
force-pushed
the
add_source_permission_metadata
branch
from
0826ce3 to
d4ad155
Compare
shreyanid
force-pushed
the
add_source_permission_metadata
branch
from
d4ad155 to
5d4a96f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to normalize permission metadata for Google Drive documents by transforming raw permission data into structured dictionaries keyed by operation type.
- Added permission normalization in both directory and file processing.
- Updated version number and changelog to reflect new functionality.
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| unstructured_ingest/processes/connectors/google_drive.py | Implements extraction and normalization of permission data |
| unstructured_ingest/version.py | Increments version number |
| CHANGELOG.md | Documents the new feature |
Files not reviewed (4)
- test/integration/connectors/expected_results/google_drive_source/file_data/1r-RDeDtKprFQWST4PCIPV618y_sBL7N7EEWg7q4kZrU.json: Language not supported
- test_e2e/expected-structured-output/google-drive/fake.docx.json: Language not supported
- test_e2e/expected-structured-output/google-drive/nested/fake.docx.json: Language not supported
- test_e2e/expected-structured-output/google-drive/test-drive-doc.docx.json: Language not supported
Comments suppressed due to low confidence (1)
unstructured_ingest/processes/connectors/google_drive.py:409
- The assignment on this line uses ':' instead of '=', which is likely a syntax error. Consider replacing ':' with '=' for proper assignment.
d.metadata.record_locator["drive_id"]: object_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retrieves the permissions available in the file data of each google drive document and normalizes the format into lists of users and groups with each type of role (read/update/delete etc).
Permission data was already being emitted from this connector, so this PR is just the type normalization step in the indexer.