Fix notion columnlist retrieval #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f7a3d86.
…eyond the 1st level)
|
@hardchor Thanks so much for diving into this! We are right in the middle of coming out with the Notion V2 as you mentioned and will make sure the dev working on this sees it. |
|
issue has been fixed in PR #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #166)
I noticed that content from
ColumnListwas missing, so decided to dive deep into what happened. In my search, I found that the current implementation only ever goes 1 level deep into theColumn, and so any more complex structures (like an expandingHeadingwith children) would get lost.I refactored the page extraction to enable recursive block extraction (within the current page). There are probably other elements where this could be applied to.
I know you're working on the v2 migration right now and appreciate you might not want to merge this PR, but just wanted to leave this here for reference.