Proma Agent [ T3 Code ] Add toast notification system with history panel#6629
Closed
1593959 wants to merge 1 commit into
Closed
Proma Agent [ T3 Code ] Add toast notification system with history panel#66291593959 wants to merge 1 commit into
1593959 wants to merge 1 commit into
Conversation
Implements a Zustand-based notification store that integrates with the existing toast system. Adds NotificationHistoryPanel accessible from the app shell with bell icon and unread count badge. - notificationStore.ts: Zustand store with addNotification, dismissNotification, clearHistory (last 50 entries) - NotificationToast.tsx: History panel with icon/color per type, timestamps, clear-all button - Wired into __root.tsx app shell Closes UnsafeLabs#862 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a toast notification system for the web app with a persistent history panel.
Implementation
notificationStore.ts— Zustand storeaddNotification({ type, title, description, durationMs })— shows a toast + records in historydismissNotification(id)— removes from historyclearHistory()— clears all historyNotificationToast.tsx— History paneltext-success,text-destructive,text-warning,text-infoIntegration
toastManagerfrom~/components/ui/toastfor renderingdurationMs@base-ui/react/toast__root.tsxapp shellFiles changed
t3code/apps/web/src/stores/notificationStore.ts(new)t3code/apps/web/src/components/NotificationToast.tsx(new)t3code/apps/web/src/routes/__root.tsx(modified — added import + mount)Closes #862
/claim #862