Skip to content

fix: global rand #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FredrikOseberg wants to merge 2 commits into
base: v6
Choose a base branch
from
+4 −15
Open

fix: global rand #217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eef21e
fix: global rand
FredrikOseberg Dec 3, 2025
c586f94
fix: whitespace
FredrikOseberg Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions internal/strategies/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"math/rand/v2"
"os"
"strconv"
"sync"
"time"

"github.com/twmb/murmur3"
)
Expand Down Expand Up @@ -63,29 +61,20 @@
return ""
}

type rng struct {
sync.Mutex
random *rand.Rand
}
type rng struct{}

func (r *rng) int() int {
r.Lock()
defer r.Unlock()
return r.random.IntN(100) + 1
return rand.IntN(100) + 1
}

func (r *rng) float() float64 {
return float64(r.int())
}

func (r *rng) string() string {
r.Lock()
defer r.Unlock()
return strconv.Itoa(r.random.IntN(10000) + 1)
return strconv.Itoa(rand.IntN(10000) + 1)
}

// newRng creates a new random number generator and uses a mutex
// internally to ensure safe concurrent reads.
func newRng() *rng {
return &rng{random: rand.New(rand.NewPCG(uint64(time.Now().UnixNano()), uint64(os.Getpid())))}
return &rng{}
}
Loading