fix: Throw a better error message if context is null #192
+43
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
If a developer forgets to render their hooks inside of a FlagProvider, the error message they get doesn't make it super clear what happened. I'm currently getting:
react.useContext(...) is null. The unleash client defaults the client to null, but none of the hooks actually treat that as an option and assume it cannot be null.I added a small hook that reads the context, and if it is null, throws a better error message. I have not made changes to the
index.tsfile, so this new hook is not exported to consumers. It's internal only to be able to throw a nicer error message.Closes #
Important files
src/useFlagContext.ts
Discussion points