Skip to content

Conversation

mpilgrem
Copy link
Collaborator

See:

We don't want to depend on Win32, but we can skip base and depend on ghc-internal directly.

@mpilgrem mpilgrem merged commit 40f9124 into master Sep 18, 2025
27 checks passed
@mpilgrem mpilgrem deleted the fix185 branch September 18, 2025 09:27
@bgamari
Copy link

bgamari commented Sep 18, 2025

@mpilgrem I would strongly advise against this. We really do not want people depending directly on ghc-internal (and even considered making it technically impossible for users to do so, although ultimately decided against this). ghc-internal is an implementation detail of GHC's standard libraries and is neither versioned nor structured for end-user consumption.

I would suggest that we revert this change such that we can discuss what is needed to avoid such a direct dependency. We are happy to introduce needed functionality into base but we want to do so in a way that avoids exposing too many implementation details, enabling a robust compatibility story in the future.

@jeltsch
Copy link

jeltsch commented Sep 18, 2025

See #187 for an alternative solution, which avoids the ghc-internal dependency.

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Sep 21, 2025

@bgamari, always happy to follow your recommendations! @jeltsch, thanks for your continued search for a way through. I'm tied up for the next week but will return to this when I am free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants