-
-
Notifications
You must be signed in to change notification settings - Fork 198
Add help button to mobile footer panel #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 18f609b.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Saira-A -- this looks good to me, but I think as we discussed on today's standup, there may be some question about whether this belongs specifically in the MobileFooterPanel or if it can be incorporated into the generic FooterPanel to make it more broadly available. See @jamesmisson's work in #1330 for a point of comparison. (We'll also need to figure out if this has any implications in combination with #1330 due to the increasing number of buttons falling into the footer).
I'm "requesting changes" to ensure that we don't merge this prematurely, but I don't necessarily think changes need to be made right away. Maybe we should discuss this further during or after tomorrow's standup, and maybe the path forward will become more clear once all of the other outstanding work on panels and buttons gets merged together over the next day or so.
Thanks so much for this work, @Saira-A! I agree with @demiankatz that the MobileFooterPanel is starting to feel a bit crowded. Just a small suggestion, I wonder if the Help button might look better positioned between the More Info and Download buttons? Totally open to discussion, but thought I'd share in case it's helpful. |
@LanieOkorodudu, also note when discussing button positions that #1330 proposes moving the "More Info" button all the way to the right side, to more clearly associate it with opening/closing the right panel. (The newly-introduced button for toggling the left panel will be all the way on the left). This change might influence the positioning of the new help button as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Saira-A!
This adds the help button from #1322 to the mobile footer panel. Switched on in config for testing - will set to false before merging.