Skip to content

Add button event to preliminary sidebar styling #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Add button event to preliminary sidebar styling #1321

wants to merge 17 commits into from

Conversation

jamesmisson
Copy link
Contributor

This removes all types and components for the original more info dialog box and makes that button trigger the right panel to open. To do so I've added a new event, TOGGLE_MOREINFO_RIGHT_PANEL (NB the existing similarly named event TOGGLE_EXPAND_RIGHT_PANEL is for when the expandable panels are full width, e.g. gallery view for the left panel).

I've then merged Jonathan's re-styling in #1320

jamesmisson and others added 17 commits February 26, 2025 17:08
@jamesmisson
fix css media query mechanism
34ad02f
@jamesmisson
fix whitespace
6a886a6
@LlGC-jop
Initial grid
a734057
@LlGC-jop
Merge remote-tracking branch 'JamesMisson/UX-mobile-moreinfo' into dev
b2010e0
@jamesmisson
trigger rightpanel with mobile footer moreinfo button
7fd6e9c
@jamesmisson
Merge remote-tracking branch 'upstream/dev' into UX-mobile-moreinfo
fc03b0d
@LlGC-jop
Add toggle function to the specific panels so classes can be set
8ec68e2
@LlGC-jop
Add open class and change animation handling to let css do it, with t…
aada409 
…imeout to account for transition time
@LlGC-jop
Comment out hiding of side panels on mobile, as they now need to be d…
2c5a1d0 
…isplayed all the time, with other css handling visibility
@LlGC-jop
More commenting to keep panels visible all the time
2b912ba
@LlGC-jop
Preliminary css to handling positioning and display of side panels
e71f90d
@github-actions
Commit from GitHub Actions (Lint code)
2add343
@LlGC-jop
Merge branch 'UniversalViewer:dev' into dev
763e374
@LlGC-jop
Move props to the root element to simulate setting html tag
94a8e0a
@LlGC-jop
Merge branch 'dev' of https://github.com/LlGC-jop/universalviewer int…
941bf47 
…o dev
@jamesmisson
Merge remote-tracking branch 'johnathan/dev' into mobile-trigger-more…
3131b2b 
…info
@jamesmisson
merge jonathan/dev
148200d
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 3:02pm

@jamesmisson jamesmisson marked this pull request as draft February 28, 2025 15:06
@jamesmisson jamesmisson requested a review from LlGC-jop February 28, 2025 15:06
@jamesmisson jamesmisson changed the title Add button even to preliminary sidebar styling Add button event to preliminary sidebar styling Feb 28, 2025
@jamesmisson jamesmisson closed this Mar 7, 2025
@jamesmisson jamesmisson mentioned this pull request Mar 7, 2025
Closed
demiankatz pushed a commit that referenced this pull request Mar 26, 2025
@jamesmisson
Improve side panel behavior in mobile interface (#1343)
1e2c4b5 
This commit makes side panel functionality fully accessible in the mobile view, where critical features were previously unreachable.

It makes responsive behavior more CSS-based and less dependent on Javascript logic.

It incorporates work from #1321, #1325, #1330, #1333 and #1337.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LlGC-jop LlGC-jop Awaiting requested review from LlGC-jop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmisson @LlGC-jop