-
Notifications
You must be signed in to change notification settings - Fork 305
feat(embedded): add link delegation extension #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -236,7 +236,32 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| { | ||
| "name": "ec.link.open_request", | ||
| "summary": "Request link presentation", | ||
| "description": "The buyer activated a link within checkout. The host MUST present the content to the buyer and respond with a success result, or notify the buyer that the request was rejected and respond with a link_rejected error.", | ||
| "params": [ | ||
| { | ||
| "name": "url", | ||
| "required": true, | ||
| "schema": { | ||
| "type": "string", | ||
| "format": "uri", | ||
| "description": "The URL of the resource to present." | ||
| } | ||
| } | ||
| ], | ||
| "result": { | ||
| "name": "linkOpenResult", | ||
| "schema": { | ||
| "type": "object", | ||
| "description": "Acknowledgement that the host handled the link.", | ||
| "additionalProperties": false | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Per #247 (comment), let's hold off on marking If we eventually want to use this pattern for Navigation Constraints/Permitted Exceptions, the host will need a way to pass data back to the iframe. Leaving the result object open allows for that future extensibility without breaking the core schema. |
||
| } | ||
| } | ||
| } | ||
| ], | ||
| "x-delegations": ["payment.instruments_change", "payment.credential"] | ||
| "x-delegations": ["payment.instruments_change", "payment.credential", "link.open"] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mandate the Host to show an error to the Buyer for invalid links? I think that's more of an implementation choice. I'd suggest this
link_rejectedif host policy prevented the navigation.