Skip to content

fix: Remove 'checkout' wrapper from doc examples#239

Open
richmolj wants to merge 1 commit intomainfrom
lr/mcp-wrapper-fix
Open

fix: Remove 'checkout' wrapper from doc examples#239
richmolj wants to merge 1 commit intomainfrom
lr/mcp-wrapper-fix

Conversation

@richmolj
Copy link
Contributor

@richmolj richmolj commented Mar 4, 2026

Description

#141 incorrectly added a checkout wrapper key in the documentation examples. This does not reflect the schema or what we believe to be correct, so fixing those examples.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@richmolj richmolj requested a review from a team as a code owner March 4, 2026 18:36
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Super-linter summary

Language Validation result
BIOME_LINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
MARKDOWN Pass ✅
PRE_COMMIT Pass ✅
TRIVY Pass ✅

All files and directories linted successfully

For more information, see the
GitHub Actions workflow run

Powered by Super-linter

@richmolj
Copy link
Contributor Author

richmolj commented Mar 4, 2026

#216 also has this fix

@igrigorik
Copy link
Contributor

Closing, resolved via #216.

@igrigorik igrigorik closed this Mar 10, 2026
@richmolj richmolj reopened this Mar 10, 2026
@richmolj richmolj requested review from a team as code owners March 10, 2026 14:49
@richmolj richmolj force-pushed the lr/mcp-wrapper-fix branch from f7294f1 to 26c499d Compare March 10, 2026 14:50
Copy link
Contributor

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — this is my bug from #141 🤦🏻

Looks like when I retrofitted the MCP structuredContent envelope onto the existing examples, I kept the "checkout"/"cart" wrapper key that was previously part of the old raw JSON-RPC result shape. Should've peeled it off on when adding the new layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants