fix(auth): prevent user/account enumeration (#274) - #394
Open
Penielka wants to merge 2 commits into
Open
Conversation
Normalize public auth responses so attackers cannot infer whether an account exists or its status (OWASP A01). Registration now returns a generic, token-less success message when the email is already taken (including Postgres unique violations) instead of a distinctive 409 conflict, and every login failure path (unknown email, deactivated account, wrong password) surfaces the same generic 401 message. Closes UnityChainxx#274 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@Penielka Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
Summary
Normalizes public auth responses so attackers can no longer infer whether an account exists or its status (OWASP A01 — Broken Access Control / user enumeration).
Changes
auth.service.ts— register409 Conflict "User with this email already exists".23505) — previously mapped to the same revealing conflict — now return the same neutral response.400without leaking internal error details.auth.service.ts— login401 "Invalid email or password". The distinct"Account has been deactivated"message, which revealed that an account existed and was inactive, is gone.New DTO —
generic-auth-message.dto.ts: neutral, token-less response body used by the registration endpoint.Tests —
auth.service.spec.tsupdated/expanded (7 passing):Verification
npx jest src/auth/services/auth.service.spec.ts— 7/7 passtsc --noEmit— no new errors in the auth module (remaining repo errors pre-exist onmain)closes [P1][backend] Prevent user/account enumeration #274
closes [P1][onchain] Add replay protection to contract answer submissions #261
closes [P1][backend] Add translation fallback and completeness checks #263
closes [P1][frontend] Add referral attribution deduplication #259