-
Notifications
You must be signed in to change notification settings - Fork 132
feat: Dedicated Game Server sample - IETs expanded [MTT-11649] #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Dedicated Game Server sample - IETs expanded [MTT-11649] #279
Conversation
Is there a reason why we have 3 categories with only a single tutorial in each of them? |
m_Untranslated: "To open the Multiplayer Play Mode window: \n\n1. Go to | ||
<b>Window</b> > <b>Multiplayer</b> > <b>Multiplayer Play Mode</b>.\n\n2. | ||
Select the checkbox for Virtual Player 2. This player opens when you enter | ||
Play mode.\n\n3. Wait for the Player status to change from inactive to | ||
active for Virtual Player 2.\n\nWhen active, the Virtual Player(s) appear | ||
in Play Mode in the main Editor Player window. A separate window opens | ||
for each enabled Player with the Player name as the window title." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page has 3 instructions in it ("open the window > enable a virtual player > wait and then press next"), which makes handholding difficult. In-Editor Tutorials are meant to be "step-by-step" and to validate that the user has done what you're asking them to do. I'd break down the "open MPPM" and "enable virtual player + wait" in two different pages.
m_Untranslated: "To open the Multiplayer Play Mode window: \n\n1. Go to | ||
<b>Window</b> > <b>Multiplayer</b> > <b>Multiplayer Play Mode</b>.\n\n2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are instructing the user to open MPPM, but the tutorial also opens it for us. If we guide the user, the tutorial window should not be open automatically and we should check, using IET's Criteria feature, that the user opened the window, and then autoadvance to the next tutorial page when they do.
If we don't guide the user, there's no point in adding "go to window, etc..." instructions.
m_TutorialButtonText: | ||
- m_Type: 1 | ||
Title: | ||
m_Untranslated: Create a Virtual Player |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not "create" virtual players, we "enable" them.
Text: | ||
m_Untranslated: "To open the Multiplayer Play Mode window: \n\n1. Go to | ||
<b>Window</b> > <b>Multiplayer</b> > <b>Multiplayer Play Mode</b>.\n\n2. | ||
Select the checkbox for Virtual Player 2. This player opens when you enter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to use the same approach we used in the Anticipation sample (and described here ) to highlight a specific virtual player (4, in this case), instead of highlighting the entire window
i see that you figured out how to check if the checkbox of a player has been enabled, using IsVirtualPlayerCreated, which is very smart! (we'll have to implement that approach too in the Anticipation tutorial of Use Cases), but unfortunately we can't check the status (activating/inactive) of players (there's no API for it), so we'll have to ask the user to wait a bit.
You can recycle the copy from this tutorial:
|
||
Note: Virtual Players do not automatically deactivate | ||
when you close the Virtual Player window. To deactivate a Virtual Player, | ||
deselect the checkbox for the active Virtual Player. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: isn't it "of the" instead of "for the"?
|
||
|
||
Continue | ||
to the next tutorial to learn how to use Network Scene Visualization.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m_TutorialButtonText: | ||
- m_Type: 1 | ||
Title: | ||
m_Untranslated: Multiplayer Virtual Player created successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: we can probably get rid of this sentence (it's implicit as you got here, and also the 1st paragraph mentions it) and directly put the "Select Done to exit this tutorial."
Description
This PR adds two In-Editor Tutorials to the project:
Issue Number(s)
MTT-11649
Contribution checklist