-
Notifications
You must be signed in to change notification settings - Fork 324
PoC for device flag clarity #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
After having this PR marinating for a while I would suggest next step is to abandon the suggested UI change and instead move flags into the Device hierarchy in the main device overview of the Input Debugger. This way, the top box, which currently suffers from IMGUI resizing difficulties would not steal precious screen space from the other 2 live logging perspectives it shares the window with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- Packages/com.unity.inputsystem/InputSystem/Editor/Internal/DeviceFlagsTreeView.cs.meta: Language not supported
{ | ||
root.AddChild(new FlagItem() | ||
{ | ||
id = 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each FlagItem is assigned the same id, which may result in duplicate IDs in the tree view. Consider generating unique ids for each flag, for example by hashing the flag value or using an incremental counter.
id = 1, | |
id = m_NextId++, |
Copilot uses AI. Check for mistakes.
EditorGUILayout.LabelField("HasEventPreProcessor", m_Device.hasEventPreProcessor ? kTrue : kFalse); | ||
EditorGUILayout.LabelField("DisabledInFrontend", m_Device.disabledInFrontend ? kTrue : kFalse); | ||
EditorGUILayout.LabelField("DisabledInRuntime", m_Device.disabledInRuntime ? kTrue : kFalse); | ||
EditorGUILayout.LabelField("DisabledWWhileInBackground", m_Device.disabledWhileInBackground ? kTrue : kFalse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Typo found in the label text "DisabledWWhileInBackground". It should likely be corrected to "DisabledWhileInBackground".
EditorGUILayout.LabelField("DisabledWWhileInBackground", m_Device.disabledWhileInBackground ? kTrue : kFalse); | |
EditorGUILayout.LabelField("DisabledWhileInBackground", m_Device.disabledWhileInBackground ? kTrue : kFalse); |
Copilot uses AI. Check for mistakes.
Description
Please fill this section with a description what the pull request is trying to address and what changes were made.
TODO Convert list into foldout to not steal screen space
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: