Skip to content

V22.2 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

V22.2 #86

wants to merge 44 commits into from

Conversation

ramchandra-kc
Copy link
Contributor

@ramchandra-kc ramchandra-kc commented Dec 13, 2022

Added features

  • start and end delimiter
  • watermark settings, watermark font, size, opacity, color
  • ipp check
  • pdf signing
  • freeze tag
  • remove last page
  • link and target element class
  • append per page
  • insert tag
  • autolink tag
  • embed tag
  • output polling
  • prepend per page
  • secret key
  • request option
  • sheet protection tag
  • cell validation tag

- remove start and end delimiter (moved to template)
- update docs
- remove unnecessary ._data
- reformatting
- change from Resource template class to Union[Template, Resource]
- change for loops to list comprehensions
- reorder imports
- refactor requests, extract variables
- use Template instead of Resource for the main template
- add template hashing tests
- cleanup
- add new getting started example
- move all tests to examples directory
- refactor code
@@ -1,82 +1,79 @@
import cloudofficeprint as cop

from test import server


def test_pdf_options():
"""Test class PDFOptions in combination with OutputConfig"""
pdf_opts = cop.config.PDFOptions(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B106: Possible hardcoded password: 'test_modify_password'


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

}
request_opt = cop.config.request_option(
"https://www.apexofficeprint.com/post/", extra_headers)
config = cop.config.OutputConfig(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B106: Possible hardcoded password: 'qwertyuiop1234'


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

name='line_chart_name',
lines=(line1, line2)
'line_chart_name',
(line1, line2)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48% of developers fix this issue

Incompatible parameter type: In call cop.elements.charts.LineChart.__init__, for 2nd positional argument, expected Tuple[Union[LineSeries, XYSeries]] but got Tuple[LineSeries, LineSeries].

❗❗ 32 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
BeginerGuide/UsingCharts/usingChart.py 51
BeginerGuide/UsingCharts/usingChart.py 60
BeginerGuide/UsingCharts/usingChart.py 66
BeginerGuide/UsingCharts/usingChart.py 70
BeginerGuide/UsingCharts/usingChart.py 91
BeginerGuide/UsingCharts/usingChart.py 112
BeginerGuide/UsingCharts/usingChart.py 137
BeginerGuide/UsingCharts/usingChart.py 155
BeginerGuide/UsingCharts/usingChart.py 161
BeginerGuide/UsingCharts/usingChart.py 167

Showing 10 of 32 findings. Visit the Lift Web Console to see all.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@@ -17,16 +18,25 @@ def __init__(self,
cloud_access_token: CloudAccessToken = None,
server_directory: str = None,
pdf_options: PDFOptions = None,
append_per_page: bool = None,):
"""
append_per_page: bool = None,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25% of developers fix this issue

Incompatible variable type: append_per_page is declared to have type bool but is used as type None.

❗❗ 153 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
cloudofficeprint/config/output.py 22
cloudofficeprint/config/output.py 23
cloudofficeprint/config/output.py 24
cloudofficeprint/config/output.py 25
cloudofficeprint/config/pdf.py 16
cloudofficeprint/config/pdf.py 17
cloudofficeprint/config/pdf.py 18
cloudofficeprint/config/pdf.py 19
cloudofficeprint/config/pdf.py 20
cloudofficeprint/config/pdf.py 21

Showing 10 of 153 findings. Visit the Lift Web Console to see all.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants