-
Notifications
You must be signed in to change notification settings - Fork 0
V22.2 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
V22.2 #86
Conversation
- change from Resource template class to Union[Template, Resource] - change for loops to list comprehensions - reorder imports - refactor requests, extract variables
- use Template instead of Resource for the main template - add template hashing tests - cleanup
- add new getting started example - move all tests to examples directory - refactor code
…in outputConfig class.
…rrent request generated documentaion
@@ -1,82 +1,79 @@ | |||
import cloudofficeprint as cop | |||
|
|||
from test import server | |||
|
|||
|
|||
def test_pdf_options(): | |||
"""Test class PDFOptions in combination with OutputConfig""" | |||
pdf_opts = cop.config.PDFOptions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B106: Possible hardcoded password: 'test_modify_password'
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
} | ||
request_opt = cop.config.request_option( | ||
"https://www.apexofficeprint.com/post/", extra_headers) | ||
config = cop.config.OutputConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B106: Possible hardcoded password: 'qwertyuiop1234'
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
name='line_chart_name', | ||
lines=(line1, line2) | ||
'line_chart_name', | ||
(line1, line2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incompatible parameter type: In call cop.elements.charts.LineChart.__init__
, for 2nd positional argument, expected Tuple[Union[LineSeries, XYSeries]]
but got Tuple[LineSeries, LineSeries]
.
❗❗ 32 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
File Path | Line Number |
---|---|
BeginerGuide/UsingCharts/usingChart.py | 51 |
BeginerGuide/UsingCharts/usingChart.py | 60 |
BeginerGuide/UsingCharts/usingChart.py | 66 |
BeginerGuide/UsingCharts/usingChart.py | 70 |
BeginerGuide/UsingCharts/usingChart.py | 91 |
BeginerGuide/UsingCharts/usingChart.py | 112 |
BeginerGuide/UsingCharts/usingChart.py | 137 |
BeginerGuide/UsingCharts/usingChart.py | 155 |
BeginerGuide/UsingCharts/usingChart.py | 161 |
BeginerGuide/UsingCharts/usingChart.py | 167 |
Showing 10 of 32 findings. Visit the Lift Web Console to see all.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
@@ -17,16 +18,25 @@ def __init__(self, | |||
cloud_access_token: CloudAccessToken = None, | |||
server_directory: str = None, | |||
pdf_options: PDFOptions = None, | |||
append_per_page: bool = None,): | |||
""" | |||
append_per_page: bool = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incompatible variable type: append_per_page is declared to have type bool
but is used as type None
.
❗❗ 153 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
File Path | Line Number |
---|---|
cloudofficeprint/config/output.py | 22 |
cloudofficeprint/config/output.py | 23 |
cloudofficeprint/config/output.py | 24 |
cloudofficeprint/config/output.py | 25 |
cloudofficeprint/config/pdf.py | 16 |
cloudofficeprint/config/pdf.py | 17 |
cloudofficeprint/config/pdf.py | 18 |
cloudofficeprint/config/pdf.py | 19 |
cloudofficeprint/config/pdf.py | 20 |
cloudofficeprint/config/pdf.py | 21 |
Showing 10 of 153 findings. Visit the Lift Web Console to see all.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Added features