Add detection promotion, canary, and rollback gates#2606
Closed
shaiananvari8 wants to merge 1 commit into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Thanks for the submission! 🙏 SecuritySkills is now issue-first: contributions need a linked issue that a maintainer has marked approved before a PR is opened. Please open an issue describing the skill, wait for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Addresses #2500
Skill Modified
Skill name: detection-engineering
Skill path:
skills/secops/detection-engineering/What Was Wrong
The skill covered Sigma authoring, ADS documentation, validation, and deployment mechanics, but its lifecycle guidance let a rule move from review/test straight into production without a required promotion decision. That misses a common detection-engineering failure mode: rules that pass lint and synthetic tests can still flood analysts, lose required fields after conversion, trigger the wrong routing path, or lack an emergency rollback owner.
What This PR Fixes
detection-engineeringto v1.0.1.Promotion, Canary, and Rollback Gatessection with concrete pass/fail evidence.Operationalcoverage definition so it requires canary promotion and rollback evidence.Promotion and Rollback Evidenceoutput table.Evidence
Before, the CI/CD stages ended at deploy and monitor:
After, production enablement requires staged proof and rollback readiness:
Test Cases Added/Updated
git diff --checkpassed.git apply --check.Bounty Tier
Bounty Info
shaiananvari8@gmail.com