Add access review non-human credential gates#1689
Open
yanziwei wants to merge 1 commit into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Closes #1688
Skill Modified
Skill name:
access-reviewSkill path:
skills/identity/access-review/SKILL.mdWhat Was Wrong
The access-review skill included service accounts in scope and flagged service accounts without owners, but it did not require reviewers to inspect each non-human credential attached to those identities. That can over-score an account as reviewed while API keys, PATs, OAuth grants, deploy keys, webhook secrets, or CI/CD tokens remain stale, over-scoped, unrotated, human-owned, or stored outside approved secret storage.
What This PR Fixes
Non-Human Credential and API Access Reviewstep.AR-NHI-*findings for missing owner, missing review coverage, broad scopes, missing rotation/expiry, dormant active credentials, stale OAuth/third-party integrations, weak storage, and human-owned automation credentials.Non-Human Credential Reviewtable.Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Docs/skill-guidance update; no executable test fixtures exist for this skill.
Validation completed locally:
git diff --check20 balanced)1.1.0,Non-Human Credential and API Access Review,AR-NHI-01,OAuth app,PAT,Non-Human Credential Review, and the credential-review pitfallBounty Tier
Bounty Info