Add ISO internal audit evidence gates#1634
Open
yZangEren wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
iso27001-gapSkill path:
skills/compliance/iso27001-gap/What Was Wrong
The skill correctly mentioned Clause 9.2 internal audit readiness, but the section was too shallow to prevent a false-ready assessment. An organization could provide an audit calendar and a final summary slide, while missing the evidence needed to prove:
This makes Clause 9.2 and Clause 10.2 readiness harder to evaluate during a real ISO 27001:2022 gap analysis.
Related review issue: #1633.
What This PR Fixes
ISO-AUDIT-01throughISO-AUDIT-07evidence gates for audit program planning, criteria/scope, impartiality, sampling, evidence retention, management reporting, and corrective action linkage.1.0.1.Evidence
Before (skill can over-credit weak audit evidence):
After (now requires auditable evidence fields):
The output report now also includes:
Test Cases Added/Updated
tests/vulnerable/)skills/compliance/iso27001-gap/tests/vulnerable/internal-audit-calendar-only.mdtests/benign/)skills/compliance/iso27001-gap/tests/benign/audit-program-with-sampling-and-closure.mdThe vulnerable fixture is a calendar-only internal audit program with self-audit, no audit criteria/scope, no sampling basis, weak retained evidence, and no corrective-action closure proof. It should trigger the new
ISO-AUDIT-*findings.The benign fixture includes criteria, scope, risk/prior-finding linkage, independence evidence, sample population and method, retained workpapers, management reporting, and a closed corrective action with effectiveness evidence. It should not trigger
ISO-AUDIT-01throughISO-AUDIT-07.Bounty Tier
Bounty Info
Validation
git diff --cached --checkbefore the fixture commit: clean.git diff --checkafter the fixture commit: clean.SKILL.mdand both new fixtures: passed.version: "1.0.1",ISO-AUDIT-01,ISO-AUDIT-07,Internal Audit Program Evidence, andCorrective Action Closure Evidence: passed.