Add Simplified Multi-tick donate #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Jan 30, 2024
src/interfaces/IPoolManager.sol
Outdated
| /// @dev If donating above the current tick (startTick > getSlot0(id).tick) the provided amounts | ||
| /// will be consumed backwards in the order that ticks are traversed i.e. amounts0[0], amounts1[0] | ||
| /// will be distributed to the highest tick and amounts0[length-1], amounts1[length-1] to the lowest. | ||
| function donate(PoolKey memory key, MultiDonateParams calldata params, bytes calldata hookData) |
There was a problem hiding this comment.
my thought was that this would also just be able to case the "donate in range" and we just expose one donate functional externally.
There was a problem hiding this comment.
And then we don't need to have separate hook permissions for different "kinds" of donate. feels odd to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#346
Description of changes
Implements a simplified multi-tick donate function. This is still a prototype therefore the DRAFT status. Many TODOs left for productionization: