Server based allocator #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update branch with main commits
merge main into server-based-allocator branch
0age
reviewed
Nov 18, 2024
0age
reviewed
Nov 18, 2024
0age
reviewed
Nov 18, 2024
| /// @inheritdoc IServerAllocator | ||
| function addSigner(address signer_) external onlyOwner { | ||
| if (_containsSigner(signer_)) { | ||
| return; |
There was a problem hiding this comment.
would it make more sense to revert here with a SignerAlreadyAdded error?
There was a problem hiding this comment.
I am personally not a fan of reverting if the expected result was achieved, but that is personal preference.
0age
reviewed
Nov 18, 2024
0age
reviewed
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a first example allocator contract that focuses on a server-based approach. While a backend would need to keep track of the allocated balances of sponsors, the contract will be used to manage signers, verify signatures of claims and handle attests for transfers. It can also consume nonces on theCompact.