fix(v4-sdk): stop cutting off addresses - use BigInt instead #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
Fix address precision issue by switching to
BigIntin_hasPermission.Description
Replaced
parseInt(address, 16)withBigInt(address)and updated all bitwise operations to useBigInt(1n << BigInt(...)).The old logic was truncating 160-bit addresses to 32 bits, causing precision loss.
Now the full address is handled correctly with no cutoff.
How Has This Been Tested?
Tested locally with multiple addresses - verified that permission checks now return correct results for large values.
Are there any breaking changes?
No breaking changes expected - only improved precision in address handling.
(Optional) Feedback Focus
Double-check that
BigIntusage aligns with the rest of the codebase and doesn’t impact performance in permission-heavy calls.(Optional) Follow Ups
Might be worth reviewing other places where addresses are parsed or masked with bitwise ops to ensure consistency.